Fixed HLM-5988_warning message

[Bhavya-egov]

No description provided.

[coderabbitai]

Walkthrough

Walkthrough

The changes in the UploadData.js component of the campaign-manager module involve refactoring the sheet iteration logic, adding validation steps, and updating toast notification handling. The closeToast function and its related useEffect were removed, and the onFileDownload function was adjusted for improved file handling.

Changes

File Path	Summary of Changes
.../campaign-manager/src/components/UploadData.js	Refactored sheet iteration logic, added validation steps, adjusted toast notifications, removed closeToast function and related useEffect, and updated onFileDownload function.

🐰✨
In code we trust, with changes bright,
Refactored logic, a coder's delight.
Toasts now smarter, validation keen,
Uploads smoother, in every scene.
Hopping forward, our code's in flight! 🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Outside diff range and nitpick comments (1)

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js (1)

Line range hint 337-358: Refactor repeated validation logic.

- for (let i = 2; i < workbook.SheetNames.length; i++) {
-   const sheetName = workbook?.SheetNames[i];
-   const sheet = workbook?.Sheets[sheetName];
-   const headersToValidate = XLSX.utils.sheet_to_json(sheet, { header: 1, })[0];
-   const jsonData = XLSX.utils.sheet_to_json(sheet, { blankrows: true });
-   const boundaryCodeIndex = headersToValidate.indexOf(t("HCM_ADMIN_CONSOLE_BOUNDARY_CODE"));
-   const headersBeforeBoundaryCode = headersToValidate.slice(0, boundaryCodeIndex);
-   const columnBeforeBoundaryCode = jsonData.map((row) => row[headersBeforeBoundaryCode[headersBeforeBoundaryCode.length - 1]]);
-   const lengthOfColumnBeforeBoundaryCode = columnBeforeBoundaryCode.filter((value) => value !== undefined && value !== "").length;
-   const filteredData = jsonData.filter((e) => e[headersBeforeBoundaryCode[headersBeforeBoundaryCode?.length - 1]]).filter((e) => e[t("HCM_ADMIN_CONSOLE_TARGET_AT_THE_SELECTED_BOUNDARY_LEVEL")]);
-   if (filteredData?.length == 0 || filteredData?.length != lengthOfColumnBeforeBoundaryCode) {
-     const errorMessage = t("HCM_MISSING_TARGET");
-     setErrorsType((prevErrors) => ({ ...prevErrors, [type]: errorMessage, }));
-     setIsError(true);
-     isValid = false;
-     break;
-   }
-   const targetValue = filteredData?.[0][t("HCM_ADMIN_CONSOLE_TARGET_AT_THE_SELECTED_BOUNDARY_LEVEL")];
-   if (targetValue <= 0 || targetValue >= 100000000) {
-     const errorMessage = t("HCM_TARGET_VALIDATION_ERROR");
-     setErrorsType((prevErrors) => ({ ...prevErrors, [type]: errorMessage, }));
-     setIsError(true);
-     isValid = false;
-     break;
-   }
- }
+ validateSheets(workbook);

Consider extracting the repeated validation logic into a separate function validateSheets to improve code readability and maintainability.

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cd09d0f and 031290c.

Files selected for processing (1)

• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js (5 hunks)

Additional Context Used

Path-based Instructions (1)

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js (1)

Pattern **/*.js: check

Additional comments not posted (2)

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js (2)

859-859: Removed closeToast function usage.

This change aligns with the PR's objective to simplify toast management by removing the closeToast function.

---

541-541: Adjusted handling of file downloads.

The adjustments in the onFileDownload function are in line with the PR's objectives to improve file handling.

[coderabbitai]

Tip

Codebase Verification

The closeToast function is still being used in multiple files across the codebase. This indicates that the removal of closeToast in UploadData.js might affect the consistency of toast notifications handling.

• micro-ui/web/micro-ui-internals/packages/modules/templates/ApplicationDetails/index.js
• micro-ui/web/micro-ui-internals/packages/modules/templates/ApplicationDetails/components/ApplicationDetailsToast.js
• micro-ui/web/micro-ui-internals/packages/modules/templates/ApplicationDetails/components/WSFeeEstimation.js
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/SetupCampaign.js
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/AddProduct.js
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/deliveryRule/AddProductscontext.js
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/deliveryRule/AddDeliverycontext.js
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/BulkUpload.js
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignSummary.js
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/SelectingBoundaries.js

Please re-evaluate the removal of closeToast in UploadData.js to ensure consistent handling of toast notifications across the application.

Analysis chain

Ensure proper handling of toast notifications.

This verification is necessary to ensure that the removal of closeToast does not affect other parts of the application that might still rely on it.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify that toast notifications are handled correctly without the `closeToast` function.

# Test: Search for toast handling in the entire codebase. Expect: No usage of `closeToast`.
rg --type js "closeToast"

Length of output: 4754