[BUGFIX] Fixed delete sync error

egordm · Aug 15, 2021 · 76df55c · 76df55c
1 parent 8011960
commit 76df55c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/notionsci/sync/structure.py b/notionsci/sync/structure.py
@@ -43,7 +43,7 @@ def push(target: ActionTarget, a: Optional[A] = None, b: Optional[B] = None) ->
 
     @staticmethod
     def delete(target: ActionTarget, a: Optional[A] = None, b: Optional[B] = None) -> 'Action[A, B]':
-        return Action(ActionType.PUSH, target, a, b)
+        return Action(ActionType.DELETE, target, a, b)
 
 
 class Sync(Generic[A, B]):
@@ -79,7 +79,7 @@ def fetch_items_b(self) -> Dict[str, B]:
 
     def compare(self, a: Optional[A], b: Optional[A]) -> Action[A, B]:
         if a is None or b is None:
-            return Action.push(ActionTarget.A if a else ActionTarget.B, a, b)
+            return Action.push(ActionTarget.A if not a else ActionTarget.B, a, b)
         return None
 
     def execute_a(self, action: Action[A, B]):

diff --git a/notionsci/sync/zotero.py b/notionsci/sync/zotero.py
@@ -37,7 +37,7 @@ def compare(self, a: Optional[A], b: Optional[Page]) -> Action[A, B]:
         if a is None:
             return Action.delete(ActionTarget.B, a, b)
         if b is None:
-            return Action.push(ActionTarget.B if a else ActionTarget.B, a, b)
+            return Action.push(ActionTarget.B, a, b)
         if a.updated_at().replace(tzinfo=pytz.utc) > b.get_property('Synced At').value().replace(tzinfo=pytz.utc) \
                 or self.force:
             return Action.push(ActionTarget.B, a, b)