-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dts infinite loop #840
Comments
Also adding to this conversation that I experience this in a different way. Updating to 6.6.3 my build stdout is: Details
Whereas on 6.6.2 it is: Details
In both cases the Detailsimport { esbuildPluginFilePathExtensions } from 'esbuild-plugin-file-path-extensions';
import { esbuildPluginVersionInjector } from 'esbuild-plugin-version-injector';
import { defineConfig } from 'tsup';
export default defineConfig({
clean: true,
dts: true,
entry: ['src/**/*.ts'],
format: ['cjs'],
minify: false,
skipNodeModulesBundle: true,
sourcemap: true,
target: 'es2020',
tsconfig: 'src/tsconfig.json',
keepNames: true,
esbuildPlugins: [esbuildPluginVersionInjector(), esbuildPluginFilePathExtensions()],
treeshake: true,
bundle: true,
splitting: false
}); So while I'm not getting the same infinite loop as OP, it does fail to resolve types. Whereas before it did consider other files for types, it no longer does now. Notably, each of them can be fixed by adding an import of The repo for this is: https://github.com/sapphiredev/framework, latest commit on main uses 6.6.2 (non caret versioning) |
I am experiencing an infinite loop as well. Downgrading to 6.6.2 fixed the issue. |
Also getting a dts related error in 6.6.3:
Running |
Same problem, reverting to 6.6.2 did the trick. |
This issue still persists on v7.2.0 preventing us from upgrading for all the new features. When can you look into this @egoist ? |
I've managed to make it work: tsup.config.ts export default defineConfig({
entry: ['index.ts'],
outDir: 'dist',
splitting: false,
sourcemap: true,
minify: false,
format: ['cjs', 'esm'],
}) Then I have my package.json scripts setup this way
|
This PR from @crutchcorn should resolve this issue. @egoist could you have a look at it when you have time? It bumps the version of Thanks! 🙏🏻 |
This issue will be solved with a new release, now that #1018 has been merged |
It seems the problem was resolved when I updated to the latest version currently version 8.0.1, previously I had this problem with version 7.x then I had to downgrade to version 6.6.2 |
Just encountered the issue in 8.0.1, downgrading to 6.6.2 helped. |
@crutchcorn Facing this issue in "^8.0.2" as well |
Adding "dist" to the exclude section in tsconfig solved my problem.
|
I think #836 may have introduced an infinite loop when compiling type declarations in watch mode. I get this in 6.6.3 when running my project with the
watch
anddts
flags:If I rollback to 6.6.2 it works as expected and only runs once.
Upvote & Fund
The text was updated successfully, but these errors were encountered: