Fix empty testdata file diff; fix simple diff bug (chainguard-dev#350)

Signed-off-by: egibs <[email protected]>
egibs · Jul 10, 2024 · 2f158fb · 2f158fb
1 parent cc54df7
commit 2f158fb
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/pkg/render/markdown.go b/pkg/render/markdown.go
@@ -42,7 +42,9 @@ func matchFragmentLink(s string) string {
 }
 
 func (r Markdown) File(ctx context.Context, fr *bincapz.FileReport) error {
-	markdownTable(ctx, fr, r.w, tableConfig{Title: fmt.Sprintf("## %s [%s]", fr.Path, mdRisk(fr.RiskScore, fr.RiskLevel))})
+	if len(fr.Behaviors) != 0 {
+		markdownTable(ctx, fr, r.w, tableConfig{Title: fmt.Sprintf("## %s [%s]", fr.Path, mdRisk(fr.RiskScore, fr.RiskLevel))})
+	}
 	return nil
 }
 

diff --git a/pkg/render/simple.go b/pkg/render/simple.go
@@ -25,7 +25,7 @@ func (r Simple) File(_ context.Context, fr *bincapz.FileReport) error {
 		return nil
 	}
 
-	if fr.Behaviors != nil {
+	if len(fr.Behaviors) != 0 {
 		fmt.Fprintf(r.w, "# %s\n", fr.Path)
 	}
 
@@ -63,7 +63,7 @@ func (r Simple) Full(_ context.Context, rep *bincapz.Report) error {
 		}
 	}
 
-	for f, fr := range rep.Diff.Removed {
+	for f, fr := range rep.Diff.Added {
 		fmt.Fprintf(r.w, "++++ added: %s\n", f)
 
 		var bs []*bincapz.Behavior

diff --git a/pkg/render/terminal.go b/pkg/render/terminal.go
@@ -91,11 +91,13 @@ func ShortRisk(s string) string {
 }
 
 func (r Terminal) File(ctx context.Context, fr *bincapz.FileReport) error {
-	renderTable(ctx, fr, r.w,
-		tableConfig{
-			Title: fmt.Sprintf("%s %s", fr.Path, darkBrackets(decorativeRisk(fr.RiskScore, fr.RiskLevel))),
-		},
-	)
+	if len(fr.Behaviors) != 0 {
+		renderTable(ctx, fr, r.w,
+			tableConfig{
+				Title: fmt.Sprintf("%s %s", fr.Path, darkBrackets(decorativeRisk(fr.RiskScore, fr.RiskLevel))),
+			},
+		)
+	}
 	return nil
 }
 

diff --git a/samples/Linux/clean/libBrokenLocale-2.27.so.simple b/samples/Linux/clean/libBrokenLocale-2.27.so.simple