Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy support and refactor codes #48

Merged
merged 13 commits into from
Dec 23, 2022
Merged

Proxy support and refactor codes #48

merged 13 commits into from
Dec 23, 2022

Conversation

eggplants
Copy link
Owner

@eggplants eggplants commented Dec 22, 2022 •
edited
Loading

Proxy feature will be worked if ALL_PROXY or HTTPS_PROXY is set.

@narugo1992 Please check.

pip install git+https://github.com/eggplants/get-pixivpy-token@proxy-support

export ALL_PROXY="..."
gppt l
gppt lh -u "..." -p "..."

narugo1992 and others added 11 commits December 15, 2022 16:05
@eggplants eggplants changed the title Proxy support Proxy support and refactor Dec 22, 2022
@eggplants eggplants changed the title Proxy support and refactor Proxy support and refactor codes Dec 22, 2022
@narugo1992
Copy link
Contributor

I see, now the gppt l is okay, but something wrong with gppt lh.

narugo1992
narugo1992 reviewed Dec 23, 2022
View reviewed changes
gppt/_selenium.py Outdated Show resolved Hide resolved
@eggplants eggplants merged commit 0abc122 into main Dec 23, 2022
@eggplants eggplants deleted the proxy-support branch December 23, 2022 06:31
@eggplants
Copy link
Owner Author

@narugo1992 Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narugo1992 narugo1992 narugo1992 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eggplants @narugo1992