fix: backgroundTasksFinished ensure all tasks finished #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atian25
reviewed
Jan 17, 2020
| @@ -390,6 +390,10 @@ module.exports = { | |||
| this._backgroundTasks = []; | |||
| return Promise.all(tasks).then(() => { | |||
| debug('finished %d background tasks', tasks.length); | |||
| if (this._backgroundTasks.length) { | |||
There was a problem hiding this comment.
那运行代码应该早就 CPU 爆掉了。
先简单处理吧，不增加这里的复杂度了。
|
3.25.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.