fix: fix httpRequest function signature #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whxaxes
reviewed
Jun 13, 2019
whxaxes
reviewed
Jun 17, 2019
whxaxes
reviewed
Jun 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
=======================================
Coverage 95.14% 95.14%
=======================================
Files 17 17
Lines 700 700
=======================================
Hits 666 666
Misses 34 34Continue to review full report at Codecov.
|
whxaxes
approved these changes
Jun 17, 2019
|
@atian25 Can you publish a new version ? I don't have package permission of this. |
|
@whxaxes had add permission, you could continue your publish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm testpassesDescription of change
change httpRequest function signature, returns actual type instead of any.