feat: add framework example #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
基于 #8 调整 |
fengmk2
reviewed
Jan 16, 2017
| "name": "framework-example", | ||
| "version": "1.0.0", | ||
| "devDependencies": { | ||
| "egg-bin": "^1.0.0" |
fengmk2
reviewed
Jan 16, 2017
| "egg-bin": "^1.0.0" | ||
| }, | ||
| "scripts": { | ||
| "dev": "egg-bin dev" |
popomore
added a commit
to eggjs/egg
that referenced
this pull request
Jan 16, 2017
|
顺便看下 https://github.com/eggjs/egg-boilerplate-framework , 两边同步下推荐的写法，看看那边的要不要优化下 |
|
再看看， @atian25 这个两个其实不用保持一致 |
atian25
reviewed
Jan 16, 2017
| let app; | ||
| before(() => { | ||
| app = mm.app({ | ||
| baseDir: path.join(__dirname, '../../../app'), |
There was a problem hiding this comment.
移到 app 了，不要要建一个重复的 fixture
| @@ -5,7 +5,7 @@ | |||
| "private": true, | |||
popomore
added a commit
to eggjs/egg
that referenced
this pull request
Jan 16, 2017
|
LGTM |
popomore
added a commit
to eggjs/egg
that referenced
this pull request
Jan 20, 2017
popomore
added a commit
to eggjs/egg
that referenced
this pull request
Jan 20, 2017
atian25
pushed a commit
to eggjs/egg
that referenced
this pull request
Jan 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.