docs: app.controller.foo instead of 'foo' #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dead-horse, thanks for your PR! By analyzing the history of the files in this pull request, we identified @leoner, @huacnlee and @tomatoo to be potential reviewers. |
|
和业务方聊的时候他们也不太能理解直接传一个字符串，再加上中间有一堆的 middleware 也不能穿字符串，更加容易混乱。 |
Codecov Report
@@ Coverage Diff @@
## master #942 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 28 28
Lines 669 669
=====================================
Hits 669 669Continue to review full report at Codecov.
|
atian25
approved these changes
May 19, 2017
docs/source/zh-cn/basics/router.md
Outdated
| }; | ||
|
|
||
| // app/router/admin.js | ||
| module.exports = app => { | ||
| app.get('/admin/user', 'admin.user'); | ||
| app.get('/admin/log', 'admin.log'); | ||
| app.get('/admin/user', app.controlleradmin.user); |
|
quickstart 也改了 |
|
+1 |
popomore
approved these changes
May 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
closes #920