Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename private method name to symbol #904

Merged
merged 1 commit into from
May 13, 2017

Conversation

iyuq
Copy link
Contributor

@iyuq iyuq commented May 12, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

rename private method use es6 symbol to make method truely private.

@mention-bot
Copy link

@iyuq, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dead-horse, @popomore and @fengmk2 to be potential reviewers.

@codecov
Copy link

codecov bot commented May 12, 2017

Codecov Report

Merging #904 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #904   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          28     28           
  Lines         667    669    +2     
=====================================
+ Hits          667    669    +2
Impacted Files Coverage Δ
lib/application.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8115c57...9a6a373. Read the comment docs.

@dead-horse dead-horse merged commit fac3e0c into eggjs:master May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants