Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loader): loadPlugin can be extended #836

Merged
merged 4 commits into from
May 4, 2017
Merged

fix(loader): loadPlugin can be extended #836

merged 4 commits into from
May 4, 2017

Conversation

popomore
Copy link
Member

@popomore popomore commented May 3, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@popomore popomore requested a review from dead-horse May 3, 2017 09:48
@codecov
Copy link

codecov bot commented May 3, 2017

Codecov Report

Merging #836 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #836   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          27     27           
  Lines         666    666           
=====================================
  Hits          666    666
Impacted Files Coverage Δ
lib/loader/app_worker_loader.js 100% <100%> (ø) ⬆️
lib/loader/agent_worker_loader.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a027ad...e1f0f01. Read the comment docs.

@popomore popomore merged commit 1358766 into master May 4, 2017
@popomore popomore deleted the load-plugin branch May 4, 2017 04:19
@popomore
Copy link
Member Author

popomore commented May 4, 2017

我发个 proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants