Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export context base classes on Application #737

Merged
merged 1 commit into from
Apr 10, 2017

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Apr 10, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@fengmk2 fengmk2 added this to the 1.0.0 milestone Apr 10, 2017
@mention-bot
Copy link

@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @atian25, @dead-horse and @popomore to be potential reviewers.

@@ -96,7 +92,7 @@ const proto = module.exports = {
if (!appLogger) return null;

// write to cache
cache[name] = new ContextLogger(this, appLogger);
cache[name] = new this.app.ContextLogger(this, appLogger);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

方便上层应用和框架覆盖默认的这些 extends

@codecov
Copy link

codecov bot commented Apr 10, 2017

Codecov Report

Merging #737 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #737   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          26     26           
  Lines         637    640    +3     
=====================================
+ Hits          637    640    +3
Impacted Files Coverage Δ
app/extend/context.js 100% <100%> (ø) ⬆️
lib/egg.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee127ad...296d7f4. Read the comment docs.

@popomore popomore merged commit c33523d into master Apr 10, 2017
@popomore popomore deleted the export-context-classes branch April 10, 2017 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants