Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typo at controller.md #720

Merged
merged 1 commit into from
Apr 6, 2017
Merged

docs: typo at controller.md #720

merged 1 commit into from
Apr 6, 2017

Conversation

lslxdx
Copy link
Contributor

@lslxdx lslxdx commented Apr 6, 2017

Checklist
  • documentation is changed or added
Affected core subsystem(s)
Description of change

将“字符数”改为“字节数”。因为Content-Length表示的是”字节数“。原文中的“字符数”不是很精确。

Content-Length表示的是字节数。原文中的“字符数”不是很精确。
@mention-bot
Copy link

@lslxdx, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dead-horse, @huacnlee and @atian25 to be potential reviewers.

@popomore
Copy link
Member

popomore commented Apr 6, 2017

注意 commit message 要加 docs:

@atian25 atian25 changed the title Update controller.md docs: typo at controller.md Apr 6, 2017
@atian25
Copy link
Member

atian25 commented Apr 6, 2017

没关系了,我们把 PR title 改了, squash 的时候注意下就好了。

@atian25 atian25 merged commit 88a1669 into eggjs:master Apr 6, 2017
@codecov
Copy link

codecov bot commented Apr 6, 2017

Codecov Report

Merging #720 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #720   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          26     26           
  Lines         640    637    -3     
=====================================
- Hits          640    637    -3
Impacted Files Coverage Δ
index.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c298c2...6426938. Read the comment docs.

@lslxdx
Copy link
Contributor Author

lslxdx commented Apr 6, 2017

@popomore 好的 👍 。第一次提交所以有点紧张,下次会注意的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants