Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove egg logger local config #695

Merged
merged 3 commits into from
Apr 14, 2017
Merged

feat: remove egg logger local config #695

merged 3 commits into from
Apr 14, 2017

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Mar 31, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@atian25 atian25 requested review from popomore and dead-horse March 31, 2017 03:56
@atian25 atian25 changed the title feat: mv egg logger local config to egg-development feat: remove egg logger local config Mar 31, 2017
@atian25
Copy link
Member Author

atian25 commented Mar 31, 2017

不移了，直接删掉。

cc @dead-horse @popomore

@popomore
Copy link
Member

popomore commented Apr 1, 2017

用例挂了？

@atian25
Copy link
Member Author

atian25 commented Apr 1, 2017

嗯，你接手修下用例？

@fengmk2
Copy link
Member

fengmk2 commented Apr 11, 2017

@atian25 should make test pass before merge.

@codecov
Copy link

codecov bot commented Apr 13, 2017 •
edited
Loading

Codecov Report

Merging #695 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #695   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          26     25    -1     
  Lines         642    641    -1     
=====================================
- Hits          642    641    -1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6be949...63289df. Read the comment docs.

@popomore
Copy link
Member

过了

@popomore
Copy link
Member

@atian25 这个我直接合了

@popomore popomore merged commit 5befb0b into master Apr 14, 2017
@popomore popomore deleted the config branch April 14, 2017 02:52
popomore added a commit that referenced this pull request May 5, 2017
@popomore
refactor: set consoleLevel WARN of coreLogger in local
0b088ca 
This config is removed by PR #695,
but the infomation of coreLogger is not useful for app developer,
and this config won't changed by app developer
@popomore popomore mentioned this pull request May 5, 2017
Merged
4 tasks
fengmk2 pushed a commit that referenced this pull request May 5, 2017
@popomore @fengmk2
refactor: set consoleLevel WARN of coreLogger in local (#850)
bd0a827 
This config is removed by PR #695,
but the infomation of coreLogger is not useful for app developer,
and this config won't changed by app developer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popomore popomore popomore approved these changes

@dead-horse dead-horse Awaiting requested review from dead-horse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

egg-logger 配置不起作用
3 participants
@atian25 @popomore @fengmk2