docs: fix reference framework path #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The framework.md docs path changed, this reference docs didn't change。
|
@kylezhang, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dead-horse, @huacnlee and @simman to be potential reviewers. |
atian25
reviewed
Mar 24, 2017
| @@ -187,7 +187,7 @@ exports.login = function* (ctx) { | |||
|
|
|||
| // 设置 Session | |||
| this.session.user = user; | |||
| // 如果用户勾选了 `记住我`，设置一个月的过期时间 | |||
| // 如果用户勾选了 `记住我`，设置一分钟的过期时间 | |||
There was a problem hiding this comment.
这个地方之前已经改过了, 是改下面的.
你的代码基线太旧了, rebase 下最新的 master
- The framework.md docs path changed, this reference docs didn't change。
atian25
approved these changes
Mar 24, 2017
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 26 26
Lines 633 633
=====================================
Hits 633 633Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
framework.mddocs path changed, this reference docs didn't change。Checklist
npm testpassesAffected core subsystem(s)
Description of change