refactor: app.cluster auto bind this #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gxcsoccer
force-pushed
the
autobind-app-to-cluster
branch
from
39cdbdc to
b9f8c5b
Compare
fengmk2
reviewed
Mar 14, 2017
| // agent worker is leader, app workers are follower | ||
| options.isLeader = this.type === 'agent'; | ||
| options.logger = this.coreLogger; | ||
| const client = cluster(clientClass, options); |
There was a problem hiding this comment.
放这里有用么？ 下面的 this 还是取不到吧，感觉需要将方法定义在下面，然后 this.cluster = this.cluster.bind(this) ?
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 26 26
Lines 632 633 +1
=====================================
+ Hits 632 633 +1
Continue to review full report at Codecov.
|
gxcsoccer
force-pushed
the
autobind-app-to-cluster
branch
from
02557ec to
a26eeb1
Compare
fengmk2
reviewed
Mar 18, 2017
| @@ -6,7 +6,8 @@ module.exports = function(app) { | |||
| const done = app.readyCallback('register_client', { | |||
| isWeakDep: app.config.runMode === 0, | |||
| }); | |||
| app.registryClient = app.cluster(RegistryClient).create(); | |||
| const cluster = app.cluster; | |||
| app.registryClient = cluster(RegistryClient).create(); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
options.cluster = app.cluster;
app.registryClient = new RegistryClient(options);这样才对的
There was a problem hiding this comment.
哦，这里的 RegistryClient 是 DataClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
plugin development
Description of change