Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add tutorials index & fix async #359

Merged
merged 1 commit into from
Feb 13, 2017
Merged

docs: add tutorials index & fix async #359

merged 1 commit into from
Feb 13, 2017

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Feb 13, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@mention-bot
Copy link

@atian25, thanks for your PR! By analyzing the history of the files in this pull request, we identified @popomore and @dead-horse to be potential reviewers.

title: 教程
---

- [渐进式开发](./progressive.md)
Copy link
Member Author

@atian25 atian25 Feb 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we move progressive to intro or advance ?

but it had link at zhihu and other

@codecov
Copy link

codecov bot commented Feb 13, 2017

Codecov Report

Merging #359 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #359   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          28     28           
  Lines         636    636           
=====================================
  Hits          636    636

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d361abe...5ead7ae. Read the comment docs.

Copy link
Member

@popomore popomore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaoshuai0102 shaoshuai0102 merged commit 05c1440 into master Feb 13, 2017
@shaoshuai0102 shaoshuai0102 deleted the tutorials branch February 13, 2017 01:56
@shaoshuai0102
Copy link
Contributor

@popomore How to deploy to eggjs.org?

@atian25
Copy link
Member Author

atian25 commented Feb 13, 2017

@shaoshuai0102 just buy a coffee and wait, travis will do it for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants