feat: lifecycle base class #3581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atian25
reviewed
Apr 1, 2019
|
PR title 应该是 feat 了，实现了 #3454 这个 RFC |
dead-horse
reviewed
Apr 1, 2019
| return this[WORKER]; | ||
| } | ||
|
|
||
| get agent() { |
There was a problem hiding this comment.
这样实现的话，this.app 和 this.agent 都可以取到值？是不是可以根据 worker.type 判断一下，避免用户误用？
There was a problem hiding this comment.
直接在 constructor 里面根据类型来赋值吧？而不是 assert 报错。
There was a problem hiding this comment.
根据类型来赋值，开发者取到 undefined，有个断言提醒会不会好一点？
Codecov Report
@@ Coverage Diff @@
## master #3581 +/- ##
======================================
Coverage 100% 100%
======================================
Files 32 34 +2
Lines 921 988 +67
======================================
+ Hits 921 988 +67
Continue to review full report at Codecov.
|
atian25
reviewed
Apr 3, 2019
whxaxes
reviewed
Apr 3, 2019
killagu
force-pushed
the
fix/agent-logger
branch
3 times, most recently
from
b7af099 to
16abfd1
Compare
atian25
reviewed
Apr 9, 2019
atian25
approved these changes
Apr 9, 2019
whxaxes
approved these changes
Apr 11, 2019
|
覆盖率那个看看？然后可以合并了。 |
killagu
force-pushed
the
fix/agent-logger
branch
from
5944380 to
56918d4
Compare
|
@atian25 可以合了 |
atian25
approved these changes
Apr 14, 2019
atian25
reviewed
Apr 29, 2019
|
|
||
| class EggAgentHook extends BaseHookClass { | ||
| configDidLoad() { | ||
| this.agent._wrapMessenger(); |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
Fixes: