Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: single mode support ignore warning #3501

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Conversation

dead-horse
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #3501 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3501      +/-   ##
==========================================
+ Coverage   99.67%   99.67%   +<.01%     
==========================================
  Files          32       32              
  Lines         921      922       +1     
==========================================
+ Hits          918      919       +1     
  Misses          3        3
Impacted Files Coverage Δ
lib/start.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ae443...227c9bd. Read the comment docs.

Copy link
Contributor

@gxcsoccer gxcsoccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dead-horse dead-horse merged commit 18efac1 into master Feb 28, 2019
@dead-horse dead-horse deleted the add-ignore-warning branch February 28, 2019 06:28
popomore pushed a commit that referenced this pull request Feb 28, 2019
feat: single mode support ignore warning (#3501)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants