Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support send without to argument #3472

Merged
merged 1 commit into from
Feb 18, 2019
Merged

fix: support send without to argument #3472

merged 1 commit into from
Feb 18, 2019

Conversation

dead-horse
Copy link
Member

@dead-horse dead-horse commented Feb 18, 2019

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

fix local messenger:

  • send() support without to
  • send() don't throw before app/agent ready and assigned

@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #3472 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3472      +/-   ##
==========================================
+ Coverage   99.67%   99.67%   +<.01%     
==========================================
  Files          32       32              
  Lines         921      922       +1     
==========================================
+ Hits          918      919       +1     
  Misses          3        3
Impacted Files Coverage Δ
lib/core/messenger/local.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf6ad1d...f4d5839. Read the comment docs.

@fengmk2 fengmk2 merged commit eac4941 into master Feb 18, 2019
@fengmk2 fengmk2 deleted the fix-local-messenger branch February 18, 2019 10:39
popomore pushed a commit that referenced this pull request Feb 18, 2019
fix: support send without to argument (#3472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants