doc：Add new loaderUpdate.md #3395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3395 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 29 29
Lines 844 844
=======================================
Hits 842 842
Misses 2 2Continue to review full report at Codecov.
|
ghost
requested review from
dead-horse
reviewed
Jan 17, 2019
|
@dead-horse：完成了，谢谢。 |
|
@whxaxes 是 ts. 挂了 |
|
@popomore 我今天处理一下 |
dead-horse
approved these changes
Jan 21, 2019
1. This will fix the issue eggjs/core#195 and gives a good answer to #3362. We should notify users how to upgrade their lifecyle events quickly. 2. Fix some '##title', we should directly use 'title:...' instead. 3. Due to the conflict of typescript of nodejs in the global/local, we've forcely defined the type path.
|
@whxaxes：谢谢你。 |
popomore
pushed a commit
that referenced
this pull request
Jan 22, 2019
doc：Add new loaderUpdate.md (#3395) 1. This will fix the issue eggjs/core#195 and gives a good answer to #3362. We should notify users how to upgrade their lifecyle events quickly. 2. Fix some '##title', we should directly use 'title:...' instead. 3. Due to the conflict of typescript of nodejs in the global/local, we've forcely defined the type path.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the issue Chore (gitignore, file_loader.test.js): Update files core#195 and gives a good answer to
beforeStartandbeforeCloseare deprecated，do we need to notify users? #3362. We should notify users how to upgrade their lifecyle events quickly.Fix some '##title', we should directly use 'title:...' instead.
Due to the conflict of typescript of nodejs in the global/local, we've forcely defined the type path.
npm testpasses