Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add comments for re-writing properties from Koa #3332

Merged
merged 1 commit into from Dec 20, 2018
Merged

fix: Add comments for re-writing properties from Koa #3332

merged 1 commit into from Dec 20, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 19, 2018

Because the version of Koa is updated to the latest version,
we cannot simply remove properties but just re-write properties
from the inherited ones. Add more comments on this.

Ref:#3329

  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Because the version of Koa is updated to the latest version,
we cannot simply remove properties but just re-write properties
from the inherited ones. Add more comments on this.
@ghost ghost requested review from whxaxes, shepherdwind and atian25 December 19, 2018 13:17
@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #3332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3332   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          29       29           
  Lines         844      844           
=======================================
  Hits          842      842           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f312db7...504d7d9. Read the comment docs.

@atian25 atian25 changed the title Fix: Add comments for re-writing properties from Koa fix: Add comments for re-writing properties from Koa Dec 20, 2018
@atian25 atian25 merged commit edfe660 into eggjs:master Dec 20, 2018
popomore pushed a commit that referenced this pull request Dec 20, 2018
fix: Add comments for re-writing properties from Koa (#3332)
@ghost ghost deleted the FixCommentOnIndex branch December 24, 2018 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant