Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(CONTRIBUTION): Add missing link for Accquire the submitted files #3102

Merged
merged 1 commit into from Oct 19, 2018
Merged

docs(CONTRIBUTION): Add missing link for Accquire the submitted files #3102

merged 1 commit into from Oct 19, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 18, 2018

Ref atian25's suggestions at: #3066.

  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ghost ghost requested a review from atian25 October 18, 2018 23:17
@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #3102 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3102   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          29       29           
  Lines         830      830           
=======================================
  Hits          828      828           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7061ec...3328fcc. Read the comment docs.

@atian25 atian25 merged commit 4abdb49 into eggjs:master Oct 19, 2018
popomore pushed a commit that referenced this pull request Oct 19, 2018
docs(CONTRIBUTION): Add missing link for `Accquire the submitted files` (#3102)

Ref atian25's suggestions at: #3066.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant