Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs (socket.io.md): Modify some statements #3068

Merged
merged 1 commit into from Oct 8, 2018
Merged

docs (socket.io.md): Modify some statements #3068

merged 1 commit into from Oct 8, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 3, 2018

Make sure that 'uws' is deprecated due to the known issue.

  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@codecov
Copy link

codecov bot commented Oct 3, 2018

Codecov Report

Merging #3068 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3068   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          29       29           
  Lines         829      829           
=======================================
  Hits          827      827           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d6798d...1cc5fd3. Read the comment docs.

Due to the issue that the author hasn't updated and destoyed the lib. So
we have to clarify it.
@ghost ghost requested a review from atian25 October 3, 2018 08:50
@atian25 atian25 requested a review from ngot October 8, 2018 01:27
@dead-horse dead-horse merged commit 4c6fb2a into eggjs:master Oct 8, 2018
popomore pushed a commit that referenced this pull request Oct 8, 2018
doc (socket.io): Make 'uws' cannot use anymore clear (#3068)

Due to the issue that the author hasn't updated and destoyed the lib. So
we have to clarify it.
@ghost ghost deleted the FixSocketIO branch October 8, 2018 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants