修改Controller中app的挂载说明 #3019

stonemakers · 2018-09-19T09:26:19Z

// app/controller/user.js
class UserController extends Controller {
  async fetch() {
    this.ctx.body = app.cache.get(this.ctx.query.id);
  }
}

经测试，无法直接在controller中使用app对象，只能够使用this.app

Checklist

npm test passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

Description of change

- [Controller 文件](./controller.md) ```js // app/controller/user.js class UserController extends Controller { async fetch() { this.ctx.body = app.cache.get(this.ctx.query.id); } } ``` 经测试，无法直接在controller中使用app对象，只能够使用this.app

codecov · 2018-09-19T09:35:33Z

Codecov Report

Merging #3019 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3019   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          29       29           
  Lines         831      831           
=======================================
  Hits          829      829           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3ffcbe...8a27d9c. Read the comment docs.

popomore · 2018-09-19T09:39:51Z

可以改成 this.ctx.app

ghost · 2018-09-20T01:21:10Z

docs/source/zh-cn/basics/objects.md

@@ -51,17 +51,6 @@ Application 对象几乎可以在编写应用时的任何一个地方获取到
  };
  ```

- [Controller 文件](./controller.md)
-


是否误删除了？

dead-horse · 2018-09-20T10:13:55Z

docs/source/zh-cn/basics/objects.md

-  // app/controller/user.js
-  class UserController extends Controller {
-    async fetch() {
-      this.ctx.body = app.cache.get(this.ctx.query.id);


这里稍微有点问题，应该是 this.app.cache

ghost · 2018-09-20T23:12:26Z

This will be merged at: #3029

1) 'app....' should be 'this.app....'. 2) 4 levels instead of 5 for each logger instance. Ref: 1) #3019 2) #3018

doc (objects.md): Fix number and code errors (#3029) 1) 'app....' should be 'this.app....'. 2) 4 levels instead of 5 for each logger instance. Ref: 1) #3019 2) #3018

atian25 mentioned this pull request Sep 19, 2018

更新提供Logger的方法数量 #3018

Closed

4 tasks

ghost reviewed Sep 20, 2018

View reviewed changes

dead-horse reviewed Sep 20, 2018

View reviewed changes

ghost mentioned this pull request Sep 20, 2018

doc (objects.md): Fix number and code errors #3029

Merged

4 tasks

ghost closed this Sep 20, 2018

ghost pushed a commit that referenced this pull request Sep 21, 2018

doc (objects.md): Fix number and code errors (#3029)

6a7db2a

1) 'app....' should be 'this.app....'. 2) 4 levels instead of 5 for each logger instance. Ref: 1) #3019 2) #3018

popomore pushed a commit that referenced this pull request Sep 21, 2018

docs: auto generate by ci

10a2c61

doc (objects.md): Fix number and code errors (#3029) 1) 'app....' should be 'this.app....'. 2) 4 levels instead of 5 for each logger instance. Ref: 1) #3019 2) #3018

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

修改Controller中app的挂载说明 #3019

修改Controller中app的挂载说明 #3019

stonemakers commented Sep 19, 2018

codecov bot commented Sep 19, 2018

popomore commented Sep 19, 2018

ghost Sep 20, 2018 •

edited by ghost

Loading

dead-horse Sep 20, 2018

ghost commented Sep 20, 2018

修改Controller中app的挂载说明 #3019

修改Controller中app的挂载说明 #3019

Conversation

stonemakers commented Sep 19, 2018

Checklist

Affected core subsystem(s)

Description of change

codecov bot commented Sep 19, 2018

Codecov Report

popomore commented Sep 19, 2018

ghost Sep 20, 2018 • edited by ghost Loading

Choose a reason for hiding this comment

dead-horse Sep 20, 2018

Choose a reason for hiding this comment

ghost commented Sep 20, 2018

ghost Sep 20, 2018 •

edited by ghost

Loading