fix: don't log when rawPacket is empty #2924
Merged
+35
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popomore
commented
Aug 21, 2018
test/lib/cluster/app_worker.test.js
Outdated
| @@ -91,6 +95,16 @@ describe('test/lib/cluster/app_worker.test.js', () => { | |||
| test2.request().path = '/foo bar'; | |||
| await test2.expect(DEFAULT_BAD_REQUEST_HTML).expect(400); | |||
| }); | |||
|
|
|||
| it.only('should not log when there is no rawPacket', done => { | |||
| const socket = net.createConnection({ port: app.port }, () => { | |||
Codecov Report
@@ Coverage Diff @@
## master #2924 +/- ##
==========================================
+ Coverage 99.75% 99.75% +<.01%
==========================================
Files 29 29
Lines 825 826 +1
==========================================
+ Hits 823 824 +1
Misses 2 2
Continue to review full report at Codecov.
|
|
其实 onClientError 异常不需要关注，互联网上大量无效请求，忽略就好。 |
|
要区分的，之前就是遇到线上问题才打印出来的。 |
|
我的意思是 onClientError 就不要打印异常日志了。 |
atian25
reviewed
Aug 23, 2018
lib/application.js
Outdated
| err.code, | ||
| err.message); | ||
| } else { | ||
| console.error(123123, '============================='); |
| module.exports = app => { | ||
| let server; | ||
| app.on('server', srv => { server = srv; }); |
popomore
force-pushed
the
client-error-rawpacket
branch
from
35ef403 to
d986505
Compare
popomore
force-pushed
the
client-error-rawpacket
branch
from
d986505 to
1b152e5
Compare
fengmk2
approved these changes
Aug 24, 2018
|
ci fail |
fengmk2
reviewed
Aug 24, 2018
test/lib/cluster/app_worker.test.js
Outdated
| @@ -62,13 +64,14 @@ describe('test/lib/cluster/app_worker.test.js', () => { | |||
| ]); | |||
| }); | |||
|
|
|||
| describe('customized client error', () => { | |||
| describe.only('customized client error', () => { | |||
There was a problem hiding this comment.
travis 有一个 debug 模式，好像可以 ssh 上去搞
popomore
pushed a commit
that referenced
this pull request
Aug 25, 2018
fix: don't log when rawPacket is empty (#2924)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change