feat(d.ts): add property of EggAppConfig.development #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reloadOnDebug - whether reload on debug, default is true. overrideDefault - whether override default watchDirs, default is false. reloadPattern - whether to reload, use https://github.com/sindresorhus/multimatch
|
@whxaxes should we just push these to |
Codecov Report
@@ Coverage Diff @@
## master #2561 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 29 29
Lines 815 815
=======================================
Hits 812 812
Misses 3 3Continue to review full report at Codecov.
|
|
@atian25 Of course it's better to import from |
whxaxes
approved these changes
May 15, 2018
|
so do it now ? |
|
Egg has already import |
dead-horse
approved these changes
May 16, 2018
popomore
pushed a commit
that referenced
this pull request
May 16, 2018
docs(d.ts): add property of EggAppConfig.development (#2561) reloadOnDebug - whether reload on debug, default is true. overrideDefault - whether override default watchDirs, default is false. reloadPattern - whether to reload, use https://github.com/sindresorhus/multimatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reloadOnDebug - whether reload on debug, default is true.
overrideDefault - whether override default watchDirs, default is false.
reloadPattern - whether to reload, use https://github.com/sindresorhus/multimatch
Checklist
npm testpassesAffected core subsystem(s)
Description of change