Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust plugins #251

Merged
merged 5 commits into from
Jan 13, 2017
Merged

adjust plugins #251

merged 5 commits into from
Jan 13, 2017

Conversation

dead-horse
Copy link
Member

@dead-horse dead-horse commented Jan 13, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change
  • 移除 cors 和 rest
  • 默认开启 static,static 现在版本懒加载,无副作用

closes #183

@dead-horse dead-horse added this to the 1.0.0 milestone Jan 13, 2017
@mention-bot
Copy link

@dead-horse, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2 and @popomore to be potential reviewers.

@atian25
Copy link
Member

atian25 commented Jan 13, 2017

i18n 要内置么?

@fengmk2
Copy link
Member

fengmk2 commented Jan 13, 2017

测试等 eggjs/onerror#10 就会修复。

Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

*/
cors: {
enable: false,
package: 'egg-cors',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dead-horse package.json 里面也删除了。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@fengmk2 fengmk2 merged commit 20571f6 into master Jan 13, 2017
@fengmk2 fengmk2 deleted the adjust-plugins branch January 13, 2017 06:48
mattma added a commit that referenced this pull request Jan 17, 2017
* master: (37 commits)
  docs: fix quickstart typo (#266)
  docs: add http client debug docs (#265)
  docs: modify and fix 3 points (#264)
  docs(intro): improve decription (#263)
  docs: fix docs site version (#262)
  docs: Fix typo.  (#261)
  docs: review 1st version docs (#257)
  fix: typo conext -> context (#259)
  docs: contributing && readme && deps (#253)
  docs: fix quickstart link in index.html (#256)
  docs: set the default locale zh-cn (#255)
  refactor: ctx.realStatus delegate ctx.response.realStatus (#252)
  docs: Add intro/index.md (#246)
  feat: adjust default plugins (#251)
  docs: add RESTful documents (#247)
  feat: delegate ctx.jsonp to ctx.response.jsonp (#248)
  chore: remove examples (#245)
  docs: improve mysql doc
  docs: add mysql doc
  docs: view (#228)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

调整默认插件
4 participants