EN translation for passport tutorial #2235

cemremengu · 2018-03-19T08:54:15Z

Added passport tutorial English documentation #363

request-info · 2018-03-19T08:54:16Z

The maintainers of this repository would appreciate it if you could provide more information.

atian25 · 2018-03-19T09:05:40Z

docs/source/en/tutorials/passport.md

+## Title: Passport
+
+** "Login authentication" ** is a common business scenario, including "account password login method" and "third-party unified login."


一个 * 且没空格

" 要改为 ` 吧?

一个 * 且没空格 : do you mean Login authentication ?

" 要改为 `` 吧?: I will replace all " with ` in this part

** "Login authentication" ** 的问题是 ** 后面多一个 * 和一个空格，这样是得不到粗体的效果的。如果直接用 ` 的话可以省掉 **

Hopefully it's good now :)

codecov · 2018-03-19T09:27:49Z

Codecov Report

Merging #2235 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2235   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files          29       29           
  Lines         773      773           
=======================================
  Hits          770      770           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fad4e1...5419d40. Read the comment docs.

cemremengu · 2018-03-30T08:58:30Z

@SunShinewyf 最后一个！

SunShinewyf · 2018-04-03T14:28:42Z

docs/source/en/tutorials/passport.md

+
+**`Login authentication`** is a common business scenario, including "account password login method" and "third-party unified login".
+


感觉那个 method 可以不要~

SunShinewyf · 2018-04-03T14:34:05Z

docs/source/en/tutorials/passport.md

+
+[Passport](http://www.passportjs.org/) is a highly scalable authentication middleware that supports the `Strategy` of `Github` ,`Twitter`,`Facebook`, and other well-known service vendors. It also supports login and authorization verification via account passwords.
+


login and authorization verification -> login authorization verification(登录授权校验)

SunShinewyf · 2018-04-03T14:43:44Z

docs/source/en/tutorials/passport.md

+
+Egg provides an [egg-passport](https://github.com/eggjs/egg-passport) plugin on top of it, encapsulating general logic such as callback processing after initialization and authentication success, allowing the developer to use Passport with just a few API calls.
+


on top of it,感觉有点不太好，换成 bases on it

encapsulating 改为 this plugin encapsulates ,指代明确一点

authentication success ->the success of authentication

allowing the developer to use Passport with just a few API calls. -> so that the developers can use ...

SunShinewyf · 2018-04-03T14:45:40Z

docs/source/en/tutorials/passport.md

+The execution sequence of [Passport](http://www.passportjs.org/) is as follows:
+
+* User access page


User accesses page

SunShinewyf · 2018-04-03T14:47:20Z

docs/source/en/tutorials/passport.md

+* User access page
+* Check Session
+* Intercept the login authentication login page


Intercept and jump to authentication login page

SunShinewyf · 2018-04-03T15:06:19Z

docs/source/en/tutorials/passport.md

+## Using Passport Ecosystem
+
+[Passport](http://www.passportjs.org/) has many middleware and it is impossible to carry out secondary packaging.


impossible to carry out secondary packaging -> impossible to have the second encapsulation

SunShinewyf · 2018-04-03T15:09:29Z

docs/source/en/tutorials/passport.md

+
+  // Render login page, user input account password
+  Router.get('/login', controller.home.login);


user inputs

SunShinewyf · 2018-04-03T15:10:27Z

docs/source/en/tutorials/passport.md

+## How to develop an egg-passport plugin
+
+In the previous section, we learned how to use a Passport middleware in the framework. We can further package it as a plugin and give back to the community.


further package -> further encapsulated

SunShinewyf · 2018-04-03T15:11:19Z

docs/source/en/tutorials/passport.md

+```
+
+Note: [egg-passport](https://github.com/eggjs/egg-passport) standardizes the configuration fields, which are unified as `key` and `secret`, so if the corresponding Passport middleware attribute names are inconsistent, the developer should perform the conversion.


perform -> do

SunShinewyf · 2018-04-03T15:12:03Z

docs/source/en/tutorials/passport.md

+[egg-passport]: https://github.com/eggjs/egg-passport
+[passport-local]: https://github.com/jaredhanson/passport-local
+[eggjs/examples/passport]: https://github.com/eggjs/examples/tree/master/passport


有一些代码片段首字母大写了~

SunShinewyf · 2018-04-07T15:04:31Z

docs/source/en/tutorials/passport.md


 Among them, we often use the latter, such as Google, GitHub, QQ unified login, which are based on [OAuth](https://oauth.net/2/) specification.

-[Passport](http://www.passportjs.org/) is a highly scalable authentication middleware that supports the `Strategy` of `Github` ,`Twitter`,`Facebook`, and other well-known service vendors. It also supports login and authorization verification via account passwords.
+[Passport](http://www.passportjs.org/) is a highly scalable authentication middleware that supports the `Strategy` of `Github` ,`Twitter`,`Facebook`, and other well-known service vendors. It also supports login authorization verification.



via account passwords 这个还是要加上的~

SunShinewyf · 2018-04-07T15:06:15Z

docs/source/zh-cn/tutorials/passport.md

@@ -248,7 +248,7 @@ $ egg-init --type=plugin egg-passport-local
 ```js
 // {plugin_root}/config/config.default.js
 // https://github.com/jaredhanson/passport-local
-exports.passportLocal = {
+module.exports.passportLocal = {
 };
 ```



该这一个地方就可以提交了~

atian25 · 2018-04-09T02:49:34Z

这个继续改改？然后 rebase 下？

cemremengu · 2018-04-12T09:09:48Z

@SunShinewyf 👀

docs(passport): translation for passport tutorial (#2235)

atian25 reviewed Mar 19, 2018

View reviewed changes

atian25 requested a review from thonatos March 19, 2018 09:06

cemremengu changed the title ~~Added passport tutorial english documentation~~ EN translation for passport tutorial Mar 19, 2018

popomore added the type: document label Mar 26, 2018

popomore requested a review from SunShinewyf March 28, 2018 05:17

SunShinewyf reviewed Apr 3, 2018

View reviewed changes

SunShinewyf reviewed Apr 7, 2018

View reviewed changes

cemremengu added 4 commits April 9, 2018 10:18

Added passport tutorial en documentation

f7d375c

fixed bold header

ea38866

Updated according to comments

a212b1d

updated according to comments

f792b68

cemremengu force-pushed the docs-passport-tutorial branch from 95a7734 to f792b68 Compare April 9, 2018 07:21

fix ch version

61b6d32

Merge branch 'master' into docs-passport-tutorial

5419d40

popomore approved these changes Apr 13, 2018

View reviewed changes

popomore merged commit ee2d2b3 into eggjs:master Apr 13, 2018

popomore pushed a commit that referenced this pull request Apr 13, 2018

docs: auto generate by ci

dce51fb

docs(passport): translation for passport tutorial (#2235)

cemremengu deleted the docs-passport-tutorial branch April 13, 2018 15:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EN translation for passport tutorial #2235

EN translation for passport tutorial #2235

cemremengu commented Mar 19, 2018 •

edited

Loading

request-info bot commented Mar 19, 2018

atian25 Mar 19, 2018

cemremengu Mar 19, 2018 •

edited

Loading

atian25 Mar 19, 2018

cemremengu Mar 19, 2018

codecov bot commented Mar 19, 2018 •

edited

Loading

cemremengu commented Mar 30, 2018

SunShinewyf Apr 3, 2018

SunShinewyf Apr 3, 2018

SunShinewyf Apr 3, 2018

SunShinewyf Apr 3, 2018

SunShinewyf Apr 3, 2018

SunShinewyf Apr 3, 2018

SunShinewyf Apr 3, 2018

SunShinewyf Apr 3, 2018

SunShinewyf Apr 3, 2018

SunShinewyf Apr 3, 2018

SunShinewyf Apr 7, 2018

SunShinewyf Apr 7, 2018

cemremengu Apr 9, 2018

atian25 commented Apr 9, 2018

cemremengu commented Apr 12, 2018

		## Title: Passport

		"Login authentication" is a common business scenario, including "account password login method" and "third-party unified login."


		`Login authentication` is a common business scenario, including "account password login method" and "third-party unified login".


		[Passport](http://www.passportjs.org/) is a highly scalable authentication middleware that supports the `Strategy` of `Github` ,`Twitter`,`Facebook`, and other well-known service vendors. It also supports login and authorization verification via account passwords.


		Egg provides an [egg-passport](https://github.com/eggjs/egg-passport) plugin on top of it, encapsulating general logic such as callback processing after initialization and authentication success, allowing the developer to use Passport with just a few API calls.

		The execution sequence of [Passport](http://www.passportjs.org/) is as follows:

		* User access page

		## Using Passport Ecosystem

		[Passport](http://www.passportjs.org/) has many middleware and it is impossible to carry out secondary packaging.


		// Render login page, user input account password
		Router.get('/login', controller.home.login);

		## How to develop an egg-passport plugin

		In the previous section, we learned how to use a Passport middleware in the framework. We can further package it as a plugin and give back to the community.

		```

		Note: [egg-passport](https://github.com/eggjs/egg-passport) standardizes the configuration fields, which are unified as `key` and `secret`, so if the corresponding Passport middleware attribute names are inconsistent, the developer should perform the conversion.

EN translation for passport tutorial #2235

EN translation for passport tutorial #2235

Conversation

cemremengu commented Mar 19, 2018 • edited Loading

request-info bot commented Mar 19, 2018

Choose a reason for hiding this comment

cemremengu Mar 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Mar 19, 2018 • edited Loading

Codecov Report

cemremengu commented Mar 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atian25 commented Apr 9, 2018

cemremengu commented Apr 12, 2018

cemremengu commented Mar 19, 2018 •

edited

Loading

cemremengu Mar 19, 2018 •

edited

Loading

codecov bot commented Mar 19, 2018 •

edited

Loading