fix: try to use custom function name first #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dead-horse 好了 |
fengmk2
commented
Mar 5, 2018
|
|
||
| const fs = require('mz/fs'); | ||
|
|
||
| module.exports = function* () { |
fengmk2
force-pushed
the
try-to-use-custom-name-first-for-2.x
branch
from
8a3f390 to
d4e2c66
Compare
dead-horse
reviewed
Mar 5, 2018
|
|
||
| const fs = require('mz/fs'); | ||
|
|
||
| module.exports = async (ctx) => { |
dead-horse
approved these changes
Mar 5, 2018
Codecov Report
@@ Coverage Diff @@
## master #2161 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 29 29
Lines 749 749
=======================================
Hits 746 746
Misses 3 3
Continue to review full report at Codecov.
|
|
fixed |
popomore
pushed a commit
that referenced
this pull request
Mar 5, 2018
fix: try to use custom function name first (#2161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick from #2156
Checklist
npm testpassesAffected core subsystem(s)
Description of change