feat: support Keep-Alive Header #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2146 +/- ##
==========================================
+ Coverage 99.59% 99.59% +<.01%
==========================================
Files 29 29
Lines 743 748 +5
==========================================
+ Hits 740 745 +5
Misses 3 3
Continue to review full report at Codecov.
|
atian25
approved these changes
Feb 28, 2018
app/middleware/meta.js
Outdated
| module.exports = options => { | ||
| module.exports = (options, app) => { | ||
| let server; | ||
| app.once('server', s => { |
app/middleware/meta.js
Outdated
| // try to support Keep-Alive Header | ||
| if (server && server.keepAliveTimeout && server.keepAliveTimeout >= 1000 && ctx.header.connection !== 'close') { | ||
| const timeout = parseInt(server.keepAliveTimeout / 1000); | ||
| ctx.set('keep-alive', `timeout=${timeout}`); |
There was a problem hiding this comment.
这个 header 不允许应用设置的，必须保证它的正确性
fengmk2
force-pushed
the
support-keep-alive-header
branch
from
92e2229 to
1db4217
Compare
|
增加 app.server |
atian25
approved these changes
Feb 28, 2018
dead-horse
approved these changes
Feb 28, 2018
|
mm.app 是不是也考虑 emit server |
popomore
approved these changes
Feb 28, 2018
|
@popomore 嗯，我加上 |
popomore
pushed a commit
that referenced
this pull request
Feb 28, 2018
feat: support Keep-Alive Header (#2146) node-modules/agentkeepalive#58
fengmk2
added a commit
to eggjs/mock
that referenced
this pull request
Feb 28, 2018
4 tasks
popomore
pushed a commit
to eggjs/mock
that referenced
this pull request
Feb 28, 2018
atian25
pushed a commit
that referenced
this pull request
Apr 3, 2019
4 tasks
atian25
pushed a commit
that referenced
this pull request
Apr 3, 2019
atian25
pushed a commit
that referenced
this pull request
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-modules/agentkeepalive#58
Checklist
npm testpassesAffected core subsystem(s)
Description of change