docs(schedule): logging && args #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2091 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 29 29
Lines 743 743
=======================================
Hits 740 740
Misses 3 3Continue to review full report at Codecov.
|
dead-horse
reviewed
Feb 7, 2018
docs/source/zh-cn/basics/schedule.md
Outdated
|
|
||
| 执行日志会输出到 `${appInfo.root}/logs/egg-schedule.log`，你也可以通过 `config.customLogger.scheduleLogger` 来自定义。 | ||
|
|
||
| 在任务中也可以通过 `ctx.loggers.scheduleLogger.info()` 来记录日志。 |
There was a problem hiding this comment.
有一个问题，这里 scheduleLogger.error 不会 redirect 到 common-error 了，我之前以为只是准备内部用的。
There was a problem hiding this comment.
好像 logger 现在不支持 2 边同时打，redirect 后就只在另一边了。
那我先干掉这段吧。
PS：可以考虑提供 app.Schedule 来给用户继承，里面可以有 this.logger
dead-horse
approved these changes
Feb 8, 2018
popomore
pushed a commit
that referenced
this pull request
Feb 8, 2018
docs(schedule): logging && args (#2091)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change