Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(faq): add the most common mistake of config #2086

Merged
merged 3 commits into from
Feb 8, 2018
Merged

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Feb 6, 2018

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@atian25 atian25 requested a review from dead-horse February 6, 2018 10:01
@codecov-io
Copy link

codecov-io commented Feb 7, 2018

Codecov Report

Merging #2086 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2086   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files          29       29           
  Lines         743      743           
=======================================
  Hits          740      740           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03a8944...d501b2b. Read the comment docs.

@@ -76,6 +76,19 @@ root | 应用根目录,只有在 local 和 unittest 环境下为 baseDir,其

`appInfo.root` 是一个优雅的适配,比如在服务器环境我们会使用 `/home/admin/logs` 作为日志目录,而本地开发时又不想污染用户目录,这样的适配就很好解决这个问题。


请根据具体场合选择合适的写法,但请确认没有写出以下代码,否则请回去复习 Node.js 基础。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后面那句不用补吧,我们还是很友好的。 😿

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

干掉了...

其实我觉得这句比起 RTFM 轻多了... RTFM 现在都不太敢用。

@dead-horse dead-horse merged commit bb4b290 into master Feb 8, 2018
@dead-horse dead-horse deleted the docs-faq-2 branch February 8, 2018 02:47
popomore pushed a commit that referenced this pull request Feb 8, 2018
docs(faq): add the most common mistake of config (#2086)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants