Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add deer stat #1974

Merged
merged 2 commits into from
Jan 18, 2018
Merged

docs: add deer stat #1974

merged 2 commits into from
Jan 18, 2018

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Jan 17, 2018

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

eggjs/doctools#30

@@ -23,3 +23,7 @@ theme: egg

less:
compress: true

deer:
spmAPos: 'a454'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@popomore 这个值会继承到上层框架去么?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好像不能继承,直接覆盖的

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我的意思是,如果 chair 那边不做任何配置的话,会直接用这个 spmAPos 么,还是会 undefined?

@codecov-io
Copy link

codecov-io commented Jan 17, 2018

Codecov Report

Merging #1974 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1974   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files          29       29           
  Lines         738      738           
=======================================
  Hits          735      735           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d7c81...d6cfbb4. Read the comment docs.

@atian25 atian25 merged commit 19fe608 into master Jan 18, 2018
@atian25 atian25 deleted the deer-stat branch January 18, 2018 11:17
popomore pushed a commit that referenced this pull request Jan 18, 2018
docs: add deer stat (#1974)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants