docs: remove async-function #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atian25
commented
Nov 24, 2017
| @@ -177,6 +179,7 @@ const { news, user } = await app.toPromise(ctx.service.biz.list(topic, uid)); | |||
| - [toAsyncFunction][app.toAsyncFunction] 和 [toPromise][app.toPromise] 实际使用的是 [co] 包装，因此会带回对应的性能损失和堆栈问题，建议开发者还是尽量全链路升级。 | |||
| - [toAsyncFunction][app.toAsyncFunction] 在调用 async function 时不会有损失。 | |||
|
|
|||
| @sindresorhus 编写了许多[基于 promise 的 helper 方法](https://github.com/sindresorhus/promise-fun)，灵活的运用它们配合 async function 能让代码更加具有可读性。 | |||
4 tasks
popomore
reviewed
Nov 29, 2017
|
|
||
| - 底层基于 Koa 1.x，异步解决方案基于 [co] 封装的 generator function。 | ||
| - 官方插件以及 Egg 核心使用 generator function 编写，保持对 Node.js LTS 版本的支持，在必要处通过 co 包装以兼容在 async function 中的使用。 | ||
| - 应用开发者可以选择 async function（Node.js 7.6+） 或者 generator function（Node.js 6.0+）进行编写，**我们推荐 generator function 方案以确保应用可以运行在 Node.js LTS 版本上**。 | ||
| - 应用开发者可以选择 async function（Node.js 7.6+） 或者 generator function（Node.js 6.0+）进行编写。 |
|
有个链接挂了 |
|
fixed |
atian25
force-pushed
the
docs-2.x-async-function
branch
from
fdeea3b to
8189a2b
Compare
|
合了? |
popomore
approved these changes
Nov 29, 2017
popomore
pushed a commit
that referenced
this pull request
Nov 29, 2017
docs: remove async-function (#1713)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change