docs(quickstart): use app.router #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1706 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 29 29
Lines 717 717
=======================================
Hits 714 714
Misses 3 3Continue to review full report at Codecov.
|
dead-horse
reviewed
Nov 23, 2017
| @@ -401,8 +403,7 @@ module.exports = SomeService; | |||
|
|
|||
| ```js | |||
| // test/app/middleware/robot.test.js | |||
| const assert = require('assert'); | |||
| const mock = require('egg-mock'); | |||
| const { app, mock, assert } = require('egg-mock/bootstrap'); | |||
|
|
|||
| describe('test/app/middleware/robot.test.js', () => { | |||
| let app; | |||
dead-horse
approved these changes
Nov 23, 2017
atian25
force-pushed
the
docs-quickstart-router
branch
from
c562737 to
d3ee530
Compare
dead-horse
reviewed
Nov 23, 2017
docs/source/en/intro/quickstart.md
Outdated
|
|
||
| describe('test/app/middleware/robot.test.js', () => { | ||
| let app; | ||
| before(() => { | ||
| app = mock.app(); |
atian25
force-pushed
the
docs-quickstart-router
branch
from
ffbccf3 to
b4ef4c1
Compare
popomore
pushed a commit
that referenced
this pull request
Nov 23, 2017
docs(quickstart): use app.router (#1706)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change