docs(middleware): use async #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1703 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 29 29
Lines 717 717
=======================================
Hits 714 714
Misses 3 3Continue to review full report at Codecov.
|
dead-horse
reviewed
Nov 23, 2017
docs/source/en/basics/middleware.md
Outdated
| - async function: `async (ctx, next) => {}` | ||
| - generator function: `function* (next) {}` |
There was a problem hiding this comment.
就这一句还好吧，因为上面还有个 框架兼容 Koa 1.x 和 2.x 支持的所有形式的中间件，包括：
There was a problem hiding this comment.
别加了，因为这个很影响性能，而且 koa 1.x 估计以后都不会怎么维护了
There was a problem hiding this comment.
感觉上面也可以不去区分 koa 1.x 和 koa 2.x 了，直接写兼容 koa 的中间件就好了
There was a problem hiding this comment.
是干掉还是注明一个 1.x 不推荐就好了？
现在 koa 社区应该还有很多存量的 koa1 中间件吧?
atian25
force-pushed
the
docs-2.x-middleware
branch
from
70ea0b6 to
5b3a98c
Compare
dead-horse
approved these changes
Nov 23, 2017
popomore
pushed a commit
that referenced
this pull request
Nov 23, 2017
docs(middleware): use async (#1703)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change