docs(quickstart): generator -> async #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1650 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 29 29
Lines 712 712
=======================================
Hits 709 709
Misses 3 3Continue to review full report at Codecov.
|
dead-horse
reviewed
Nov 13, 2017
docs/source/en/intro/quickstart.md
Outdated
| @@ -349,14 +352,14 @@ that checks the User-Agent. | |||
| // app/middleware/robot.js | |||
| // options === app.config.robot | |||
| module.exports = (options, app) => { | |||
| return function* robotMiddleware(next) { | |||
| return async function robotMiddleware(next) { | |||
There was a problem hiding this comment.
async function (ctx, next) 下面的 this 都要改成 ctx
dead-horse
reviewed
Nov 13, 2017
| @@ -323,14 +327,14 @@ exports.relativeTime = time => moment(new Date(time * 1000)).fromNow(); | |||
| // app/middleware/robot.js | |||
| // options === app.config.robot | |||
| module.exports = (options, app) => { | |||
| return function* robotMiddleware(next) { | |||
| return async function robotMiddleware(next) { | |||
atian25
force-pushed
the
docs-2.x-quickstart
branch
2 times, most recently
from
db21418 to
b1decfb
Compare
atian25
force-pushed
the
docs-2.x-quickstart
branch
from
b1decfb to
cb068e7
Compare
dead-horse
approved these changes
Nov 13, 2017
popomore
pushed a commit
that referenced
this pull request
Nov 13, 2017
docs(quickstart): generator -> async (#1650)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change