feat: add Subscription #1469
Merged
feat: add Subscription #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@popomore 这个也要发掉了，不然 egg-schedule 的新用户按文档写会报错 |
|
ping |
popomore
force-pushed
the
Subscription
branch
2 times, most recently
from
43f0d5c to
1b121dc
Compare
Codecov Report
@@ Coverage Diff @@
## master #1469 +/- ##
==========================================
+ Coverage 99.71% 99.72% +<.01%
==========================================
Files 29 29
Lines 714 715 +1
==========================================
+ Hits 712 713 +1
Misses 2 2
Continue to review full report at Codecov.
|
popomore
force-pushed
the
Subscription
branch
from
bf61f7f to
a3f6407
Compare
|
@atian25 看看 |
atian25
approved these changes
Oct 19, 2017
docs/source/en/basics/objects.md
Outdated
| const Subscription = require('egg').Subscription; | ||
| class Schedule extends Subscription { | ||
| // This method should be implemented | ||
| * subscribe() {} |
There was a problem hiding this comment.
这里可以是 generator / promise / async 吧?
There was a problem hiding this comment.
subscribe could be generator / async function
atian25
reviewed
Oct 20, 2017
docs/source/zh-cn/basics/objects.md
Outdated
| @@ -270,6 +270,22 @@ module.exports = { | |||
|
|
|||
| 我们可以在 Controller 和 Service 实例上通过 `this.logger` 获取到它们，它们本质上就是一个 Context Logger，不过在打印日志的时候还会额外的加上文件路径，方便定位日志的打印位置。 | |||
|
|
|||
| ## Subscription | |||
|
|
|||
| Subscription 是一种订阅模型，消息中间件的消费者或调度任务都属于这种模式。 | |||
There was a problem hiding this comment.
订阅模型是一种比较常见的开发模式，譬如消息中间件的消费者或调度任务。因此我们提供了 Subscription 基类来规范化这个模式。
使用方式如下：
...
...
...
开发者可以根据自己的需求，基于它定制特定的订阅规范，如 [定时任务](./schedule.md) 就是使用这种模式实现的，建议开发者可以参考来实现自己的消息中间件。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
Ref #1468