fix: log cookie's key when cookie exceed limit length (#1996)

eggjs · Jan 22, 2018 · aa46eb2 · aa46eb2
1 parent 7993b45
commit aa46eb2
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/lib/application.js b/lib/application.js
@@ -271,6 +271,7 @@ class Application extends EggApplication {
     this.on('cookieLimitExceed', ({ name, value, ctx }) => {
       const err = new Error(`cookie ${name}'s length(${value.length}) exceed the limit(4093)`);
       err.name = 'CookieLimitExceedError';
+      err.key = name;
       err.cookie = value;
       ctx.coreLogger.error(err);
     });

diff --git a/test/lib/application.test.js b/test/lib/application.test.js
@@ -200,5 +200,21 @@ describe('test/lib/application.test.js', () => {
           .expect(200);
       });
     });
+
+    describe('on cookieLimitExceed', () => {
+      it('should log error', done => {
+        const ctx = {
+          coreLogger: {
+            error(err) {
+              assert(err.key === 'name');
+              assert(err.cookie === 'value');
+              assert(err.name === 'CookieLimitExceedError');
+              done();
+            },
+          },
+        };
+        app.emit('cookieLimitExceed', { name: 'name', value: 'value', ctx });
+      });
+    });
   });
 });