Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature - Load The Model Of Plugin & Framework #31

Closed
wants to merge 2 commits into from
Closed

New Feature - Load The Model Of Plugin & Framework #31

wants to merge 2 commits into from

Conversation

trylovetom
Copy link
Collaborator

@trylovetom trylovetom commented Feb 26, 2019

Description of change

Change the path of loadModelToApp
load one time -> load any model of plugin and framework
baseDir/app/model -> plugin/app/model, framework/app/model

修改了 loadModelToApp 的路徑,模仿 loadService 的繼承載入方式。

load ones -> load plugin and framework
baseDir/app/model -> plugin/app/model, framework/app/model
@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #31   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          46     46           
=====================================
  Hits           46     46
Impacted Files Coverage Δ
lib/mongoose.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d616409...d65412a. Read the comment docs.

@atian25 atian25 requested a review from popomore February 27, 2019 05:47
@trylovetom
Copy link
Collaborator Author

@atian25 If he is busy, maybe I can be a contributions.

@atian25
Copy link
Member

atian25 commented Feb 28, 2019

@popomore should we load all app/model including plugins? or use your custom-loader config, so it doesn't load by default but a user could enable this feature by config.

@trylovetom
Copy link
Collaborator Author

@atian25 you are right, I think that I can make a custom-loader like egg-mongoose-auto-load-model-and-plugin.

@trylovetom trylovetom closed this Feb 28, 2019
@trylovetom trylovetom deleted the patch-2 branch February 28, 2019 18:15
@atian25
Copy link
Member

atian25 commented Feb 28, 2019

I means eggjs/egg#3480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants