fix: hide password for security #30
Conversation
The logger will print the password. That's not secure. This patch will hide it.
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 46 46
=====================================
Hits 46 46
Continue to review full report at Codecov.
|
|
@jtyjty99999 please, review my code, thx |
|
@atian25 |
|
he seems busy... I will notify he by dingtalk. |
|
@atian25 Any Update? If he is busy, maybe I can be a contributor. |
|
sure, really sorry for this. I'll review it, wait for a minute. |
| @@ -56,7 +56,7 @@ function createOneClient(config, app) { | |||
| if (!options.hasOwnProperty('useNewUrlParser')) { | |||
| options.useNewUrlParser = true; | |||
| } | |||
| app.coreLogger.info('[egg-mongoose] connecting %s', url); | |||
There was a problem hiding this comment.
could use some lib, such as https://github.com/tanzim/url-mask
|
@trylovetom collaborators invite is sent. |
|
@atian25 Roger that, Captain! |
|
能不能把 mongoose 升级到官方最新稳定版本？ |
PR is welcome |
|
@trylovetom any update? |
|
@atian25 交給我，最近剛忙完案子，預計明天可以更新 PR |
|
next time, not need to close, just push. feature branch is allowed |
The logger will print the password. That's not secure. This patch will hide it.
Affected core subsystem(s)
mongodb://root:pass@mongo:27017/admin->mongodb://root:xxxxx@mongo:27017/adminDescription of change
filter the password before log it