feat: first implement #2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,14 +9,33 @@ module.exports = app => { | |
| assert(config.url, '[egg-mongoose] url is required on config'); | ||
| app.coreLogger.info('[egg-mongoose] connecting %s', config.url); | ||
|
|
||
| const db = mongoose.createConnection(); | ||
| db.Schema = mongoose.Schema; | ||
| app.mongoose = db; | ||
|
|
||
| function connect() { | ||
| db.open(config.url, config.options); | ||
|
There was a problem hiding this comment. open 会返回一个 promise，用 beforeStart 吧 |
||
| } | ||
|
|
||
| connect() | ||
|
|
||
|
|
||
| db.on('error', (err) => { | ||
| app.coreLogger.info('[egg-mongoose] %s error: ', err.message); | ||
|
There was a problem hiding this comment. 要打印 error 对象，否则堆栈会丢失。 db.on('error', err => {
err.message = `[egg-mongoose]${err.message}`;
app.coreLogger.info(err);
}); |
||
| }); | ||
|
|
||
| db.on('disconnected', () => { | ||
| app.coreLogger.info('[egg-mongoose] %s disconnected', config.url); | ||
|
|
||
| connect(); | ||
|
There was a problem hiding this comment. mongoose 不会自动重连的么？需要手动再发起一次 open？ 我记得底层的 node-mongodb-native 是有自动重连的，这里不做任何延迟立刻重连看起来有问题 There was a problem hiding this comment. @dead-horse 嗯，node-mongodb-native 是有自动重连的，可以在 options 设置重试次数和间隔时间 |
||
| }); | ||
|
|
||
| db.on('connected', () => { | ||
| app.coreLogger.info('[egg-mongoose] connected %s successfully', config.url); | ||
| }); | ||
|
|
||
| db.on('reconnected', () => { | ||
| app.coreLogger.info('[egg-mongoose] reconnected %s successfully', config.url); | ||
| }); | ||
|
|
||
| loadModel(app); | ||
|
|
||
| app.beforeStart(function* () { | ||
|
There was a problem hiding this comment. 直接 function 返回 promise 就行了吧 app.beforeStart(function() {
app.coreLogger.info('[egg-mongoose] starting...');
return db.open(config.url, config.options);
}); |
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
两个 * ？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
给出 options 的文档链接