-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: upgrade dependencies #11
Conversation
@popomore, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2 and @jtyjty99999 to be potential reviewers. |
egg-bin 增加了超时时间,应该可以稳定一点 |
package.json
Outdated
"egg-bin": "^3.6.0", | ||
"egg-ci": "^1.7.0", | ||
"egg-mock": "^3.7.2", | ||
"eslint": "^3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
怎么降了?
感觉 schedule 还是要支持 close 的,不然这里都过不了 |
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
=======================================
Coverage 95.65% 95.65%
=======================================
Files 12 12
Lines 184 184
=======================================
Hits 176 176
Misses 8 8 Continue to review full report at Codecov.
|
@@ -40,10 +40,11 @@ | |||
}, | |||
"scripts": { | |||
"lint": "eslint .", | |||
"test": "npm run lint -- --fix && npm run test-local", | |||
"pkgfiles": "egg-bin pkgfiles", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感觉这句不要加了,直接在下面 2 个地方加上就好了。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没关系吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯,都行。合了发版本吧。
Checklist
npm test
passesAffected core subsystem(s)
Description of change