Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: upgrade dependencies #11

Merged
merged 3 commits into from
Oct 12, 2017
Merged

test: upgrade dependencies #11

merged 3 commits into from
Oct 12, 2017

Conversation

popomore
Copy link
Member

@popomore popomore commented Jun 14, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@mention-bot
Copy link

@popomore, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2 and @jtyjty99999 to be potential reviewers.

@popomore
Copy link
Member Author

egg-bin 增加了超时时间,应该可以稳定一点

package.json Outdated
"egg-bin": "^3.6.0",
"egg-ci": "^1.7.0",
"egg-mock": "^3.7.2",
"eslint": "^3.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

怎么降了?

@popomore
Copy link
Member Author

感觉 schedule 还是要支持 close 的,不然这里都过不了

@popomore popomore changed the title test: upgrade dependencies WIP: test: upgrade dependencies Jun 14, 2017
@codecov-io
Copy link

codecov-io commented Oct 11, 2017

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files          12       12           
  Lines         184      184           
=======================================
  Hits          176      176           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 679a465...6af3189. Read the comment docs.

@popomore popomore changed the title WIP: test: upgrade dependencies test: upgrade dependencies Oct 12, 2017
@popomore
Copy link
Member Author

@atian25

@@ -40,10 +40,11 @@
},
"scripts": {
"lint": "eslint .",
"test": "npm run lint -- --fix && npm run test-local",
"pkgfiles": "egg-bin pkgfiles",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉这句不要加了,直接在下面 2 个地方加上就好了。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没关系吧

Copy link
Member

@atian25 atian25 Oct 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯,都行。合了发版本吧。

@atian25 atian25 merged commit 5e6c563 into master Oct 12, 2017
@atian25 atian25 deleted the deps branch October 12, 2017 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants