Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update init_command.js #85

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Update init_command.js #85

merged 1 commit into from
Jan 6, 2024

Conversation

zhennann
Copy link
Contributor

@zhennann zhennann commented Jan 6, 2024

remove this.pkgInfo

remove this.pkgInfo
@fengmk2
Copy link
Member

fengmk2 commented Jan 6, 2024

这是要解决一个什么问题?

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (78e014f) 72.29% compared to head (dd48e73) 72.24%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   72.29%   72.24%   -0.06%     
==========================================
  Files           1        1              
  Lines         545      544       -1     
  Branches       56       56              
==========================================
- Hits          394      393       -1     
  Misses        151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhennann
Copy link
Contributor Author

zhennann commented Jan 6, 2024

这个变量this.pkgInfo应该是以前用于检测egg版本更新的。我看新版已经去掉了egg版本更新的功能,那么这个变量也就变成孤立的了。

@fengmk2 fengmk2 merged commit 7615d4a into eggjs:master Jan 6, 2024
9 checks passed
fengmk2 pushed a commit that referenced this pull request Jan 6, 2024
[skip ci]

## [3.0.2](v3.0.1...v3.0.2) (2024-01-06)

### Bug Fixes

* remove unuse pkgInfo ([#85](#85)) ([7615d4a](7615d4a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants