fix: don't create plugin index by tools, should support i18n (#16)

eggjs · Jun 2, 2017 · 9e742fe · 9e742fe
1 parent 9f7c242
commit 9e742fe
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 8 deletions.
diff --git a/lib/base.js b/lib/base.js
@@ -156,8 +156,6 @@ class DocToolsBase extends Command {
       data += `- ${name}\n`;
     }
 
-    yield fs.writeFile(path.join(sourceDir, 'en/plugins/index.md'), 'layout: plugin\n---\n');
-    yield fs.writeFile(path.join(sourceDir, 'zh-cn/plugins/index.md'), 'layout: plugin\n---\n');
     yield this._writeData('plugins.yml', data);
   }
 

diff --git a/lib/themes/egg/layout/plugin.swig b/lib/themes/egg/layout/plugin.swig
@@ -1,6 +1,6 @@
 <div class="page-main">
   <article class="markdown-body">
-    <h1>内置插件列表</h1>
+    <h1>{{page.title}}</h1>
     <ul>
     {% for plugin in site.data.plugins %}
       <li>

diff --git a/test/build.test.js b/test/build.test.js
@@ -87,18 +87,18 @@ describe('test/build.test.js', () => {
       const pluginData = yield fs.readFile(path.join(target, 'source/_data/plugins.yml'), 'utf8');
       assert(pluginData.includes('- onerror\n'));
 
-      let pluginIndex = yield fs.readFile(path.join(target, 'source/zh-cn/plugins/index.md'), 'utf8');
-      assert(pluginIndex.includes('layout: plugin\n'));
-      pluginIndex = yield fs.readFile(path.join(target, 'source/en/plugins/index.md'), 'utf8');
-      assert(pluginIndex.includes('layout: plugin\n'));
-
       const pluginDocs = yield fs.readdir(path.join(target, 'source/zh-cn/plugins'));
       assert(pluginDocs.length === 14);
 
       let pluginA = yield fs.readFile(path.join(target, 'source/zh-cn/plugins/a.md'), 'utf8');
       assert(pluginA.includes('中文文档'));
       pluginA = yield fs.readFile(path.join(target, 'source/en/plugins/a.md'), 'utf8');
       assert(pluginA.includes('English Document'));
+
+      let pluginIndex = yield fs.readFile(path.join(target, 'public/zh-cn/plugins/index.html'), 'utf8');
+      assert(pluginIndex.includes('内置插件列表'));
+      pluginIndex = yield fs.readFile(path.join(target, 'public/en/plugins/index.html'), 'utf8');
+      assert(pluginIndex.includes('Plugin List'));
     });
   });
 

diff --git a/test/fixtures/framework/docs/source/en/plugins/index.md b/test/fixtures/framework/docs/source/en/plugins/index.md
@@ -0,0 +1,3 @@
+layout: plugin
+title: Plugin List
+---
diff --git a/test/fixtures/framework/docs/source/zh-cn/plugins/index.md b/test/fixtures/framework/docs/source/zh-cn/plugins/index.md
@@ -0,0 +1,3 @@
+layout: plugin
+title: 内置插件列表
+---