fix: separte agent and application start time #278
Conversation
WalkthroughThe pull request encompasses documentation updates and test modifications for the Egg.js framework. The changes primarily focus on improving documentation clarity in the README.md, updating timing log messages in the lifecycle module to include application type, and enhancing test cases to handle asynchronous operations. The modifications aim to provide more descriptive logging and ensure robust testing of the application initialization process. Changes
Sequence DiagramsequenceDiagram
participant App as EggCore Application
participant Lifecycle as Lifecycle Module
participant Timing as Timing Service
App->>Lifecycle: Initialize
Lifecycle->>Timing: start(`${app.type} Start`)
Lifecycle->>Timing: end(`${app.type} Start`)
Timing-->>Lifecycle: Record Timing Metrics
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
🔇 Additional comments (6)src/lifecycle.ts (2)
The change enhances logging by including the application type in the timing message, making it easier to distinguish between agent and application timing logs.
The end timing message correctly matches the corresponding start timing message, maintaining consistency in the logs. test/egg.test.ts (4)
The test assertion has been properly updated to verify the new application timing message format.
The test assertion has been properly updated to verify the new agent timing message format.
The test assertion for error cases has been properly updated to verify the new timing message format.
The test has been enhanced to properly handle asynchronous operations by awaiting the completion of application loading and ready state. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
commit: |
[skip ci] ## [6.2.4](v6.2.3...v6.2.4) (2024-12-20) ### Bug Fixes * separte agent and application start time ([#278](#278)) ([6852046](6852046))
Summary by CodeRabbit
Documentation
README.mdfor improved clarity and structure, including expanded sections on timing metrics and method descriptions.Bug Fixes
Tests
EggCoreapplication.