feat: add new mixin loadCustomLoader in Loader #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popomore
force-pushed
the
custom-loader
branch
from
a39dac1 to
acfca7e
Compare
|
太需要这个功能了！文档也得一起写上。 |
fengmk2
reviewed
Feb 28, 2019
| module.exports = { | ||
| customLoader: { | ||
| adapter: { | ||
| directory: 'app/adapter', |
There was a problem hiding this comment.
还得支持 filter，例如过滤 _ 开始的文件（如 _foo.js 不希望被加载）。
There was a problem hiding this comment.
支持的，直接传递 loader 那个 options 进去就好了
atian25
approved these changes
Feb 28, 2019
| const defaultConfig = { | ||
| caseStyle: 'lower', | ||
| initializer(Class) { | ||
| return new Class(loader.app); |
There was a problem hiding this comment.
如果 load 的是 app/ultis 这种 exports 方式的，会不会有问题
|
文档也补充一下呗，其他 lgtm |
|
文档在这里 eggjs/egg#3484 |
|
+1 发吧 |
atian25
reviewed
Mar 1, 2019
Co-Authored-By: popomore <[email protected]>
|
没问题我先发一版 |
atian25
approved these changes
Mar 6, 2019
hyj1991
pushed a commit
to hyj1991/egg-core
that referenced
this pull request
Sep 16, 2021
<!-- Thank you for your pull request. Please review below requirements. Bug fixes and new features should include tests and possibly benchmarks. Contributors guide: https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md 感谢您贡献代码。请确认下列 checklist 的完成情况。 Bug 修复和新功能必须包含测试，必要时请附上性能测试。 Contributors guide: https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md --> ##### Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [x] `npm test` passes - [x] tests and/or benchmarks are included - [x] documentation is changed or added - [x] commit message follows commit guidelines ##### Affected core subsystem(s) <!-- Provide affected core subsystem(s). --> ##### Description of change <!-- Provide a description of the change below this comment. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change