Skip to content

Commit

Permalink
kata_proxy: Open a special goroutine do cmd.Wait
Browse files Browse the repository at this point in the history
Got a defunct kata-proxy after kata quit when VMCache is enabled.
The reason is vmcache server opens kata-proxy but doesn't wait it.

If VMCache is disabled, kata-runtime will quit before kata-proxy.
So it will not meet the issue.

Open a special goroutine do cmd.Wait in kataProxy.start to handle
the isssue.

Fixes: kata-containers#1678

Signed-off-by: Hui Zhu <[email protected]>
  • Loading branch information
teawater committed May 15, 2019
1 parent 86d51f5 commit 00d03c1
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions virtcontainers/kata_proxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ func (p *kataProxy) start(params proxyParams) (int, string, error) {
return -1, "", err
}

go cmd.Wait()

return cmd.Process.Pid, proxyURL, nil
}

Expand Down

0 comments on commit 00d03c1

Please sign in to comment.