Fix SIGSEGV on update error

egegunes · May 12, 2020 · 0dae7eb · 0dae7eb
1 parent 62350b7
commit 0dae7eb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## [0.3.1] - 2020-05-12
+### Fixed
+- Panic with runtime error on trying to update non existent variable or project
+
 ## [0.3.0] - 2020-05-01
 ### Added
 - New command (`lint`) for validating .gitlab-ci.yml files

diff --git a/cmd/env_update.go b/cmd/env_update.go
@@ -35,9 +35,8 @@ var envUpdateCmd = &cobra.Command{
 			EnvironmentScope: &scope,
 		}
 
-		variable, _, err := git.ProjectVariables.UpdateVariable(pid, key, variableOptions, nil)
-		fmt.Fprintf(os.Stderr, "updating %s...", variable.Key)
-
+		_, _, err := git.ProjectVariables.UpdateVariable(pid, key, variableOptions, nil)
+		fmt.Fprintf(os.Stderr, "updating %s...", key)
 		if err != nil {
 			fmt.Fprintf(os.Stderr, "%s\n", RED("error"))
 			fmt.Fprintf(os.Stderr, "couldn't update variable: %v\n", err)